Skip to content

fix!: standardize config param names for Algorithm::SetOption #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
c-dilks wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

fix!: standardize config param names for Algorithm::SetOption #425

c-dilks wants to merge 10 commits into from

Conversation

@c-dilks
Copy link
Member

@c-dilks c-dilks commented Jan 22, 2026 •
edited
Loading

The key parameter of Algorithm::SetOption is manually determined, typically from the Algorithm::GetOption* methods. Instead:

  • generate the key name from the YAML node path's string elements, delimiting elements by "/"
  • throw an exception if a user uses SetOption with an old key name, and print the new name

@github-project-automation github-project-automation bot moved this to Unsorted in Iguana Jan 22, 2026
@c-dilks c-dilks force-pushed the standardize-setoption branch from 6600115 to 52cb87f Compare January 23, 2026 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rtysonCLAS12 rtysonCLAS12 Awaiting requested review from rtysonCLAS12 rtysonCLAS12 will be requested when the pull request is marked ready for review rtysonCLAS12 is a code owner

@Gregtom3 Gregtom3 Awaiting requested review from Gregtom3 Gregtom3 will be requested when the pull request is marked ready for review Gregtom3 is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

Iguana
Status: Unsorted

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@c-dilks